[Issue 2665] Add search path to db connection params #2836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidDudas-Intuitial
requested review from
coilysiren,
widal001 and
acouch
as code owners
coilysiren
previously approved these changes
Nov 13, 2024
6 tasks
chouinar
reviewed
Nov 13, 2024
| @@ -52,6 +52,7 @@ def get_connection_parameters(config: DBSettings) -> dict[str, Any]: | |||
| token = ( | |||
| config.password if config.local_env is True else generate_iam_auth_token(config) | |||
| ) | |||
| search_path = "public" if config.local_env is True else "app" | |||
There was a problem hiding this comment.
I'd put this more explicitly in an environment variable in the config class itself.
Something like:
db_schema: str = Field("app", alias="DB_SCHEMA")Then in local.env, put DB_SCHEMA=public
This makes it much easier to adjust or configure.
There was a problem hiding this comment.
Done! Please see latest commit
chouinar
reviewed
Nov 13, 2024
| @@ -17,6 +17,7 @@ class DBSettings(PydanticBaseEnvConfig): | |||
| user: str = Field (alias="DB_USER") | |||
| password: Optional[str] = Field(None, alias="DB_PASSWORD") | |||
| ssl_mode: str = Field("require", alias="DB_SSL_MODE") | |||
| db_schema: str = Field ("app", alias="DB_SCHEMA") | |||
There was a problem hiding this comment.
You would need to set something in local.env as well to override this to be public locally.
There was a problem hiding this comment.
I did that locally but did not commit the changes
There was a problem hiding this comment.
I'll push it up now
chouinar
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2665
Time to review: 1 min
Changes proposed
Added search path to db connection params.
Context for reviewers
This is latest step in a series of attempts to resolve failed db connections and privileges from /analytics step functions. See ticket history and comments for details.
Additional information