Ds/renovate i18next http backend #3158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-s-nava
force-pushed
the
ds/renovate-i18next-http-backend
branch
from
0b71b9b to
b6c149e
Compare
acouch
reviewed
Dec 16, 2024
There was a problem hiding this comment.
@doug-s-nava I don't think we are using i18next-... packages anymore since we moved to next-intl. These might be better off being removed?
|
I tried removing them: #3229 |
|
Approved #3229 so closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes unticketed
Time to review: 15 mins
Changes proposed
This is an update to the renovate PR to update i18n-next #2595
The renovate PR pushes i18next-http-backend to 2.7, which has been deprecated by the maintainer. As 2.7 contained a breaking change and introduced a possible bug, we should be pointing at the latest version, 3.0.1 instead
see i18next/i18next-http-backend#161
Context for reviewers
Test steps can be found in gitbook, but I can't find them at the moment. Did the private gitbook go away?
In general, make sure you can build the app, and run the app and storybook locally
Additional information