Skip to content

Commit

Permalink
Fix reference cycle caused by EditableBMLabelProxy
Browse files Browse the repository at this point in the history
this would cause the parent to not be free'd properly, creating a
phantom EditorUI which is the source of many crashes.

In my testing, this has eliminated any consistent crashes I was getting
  • Loading branch information
matcool committed Feb 13, 2024
1 parent 7167ad9 commit 662df72
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/utils/EditableBMLabelProxy.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ using namespace geode::prelude;
class EditableBMLabelProxy : public CCLabelBMFont, TextInputDelegate {
protected:
Ref<InputNode> m_input = nullptr;
Ref<CCNode> m_inputParent = nullptr;
CCNode* m_inputParent = nullptr;
std::function<void(std::string const&)> m_onSetValue = nullptr;
std::function<void(std::string const&)> m_onUpdate = nullptr;
bool m_ignoreLabelUpdate = false;
Expand Down

0 comments on commit 662df72

Please sign in to comment.