Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix realpath failing when $DATA_HOME is missing #1639

Merged
merged 2 commits into from
Feb 19, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/remote_workspace
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

# exit on error
set -e
Expand Down
3 changes: 3 additions & 0 deletions scripts/resolve_data_home
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ HOME="${HOME:-$(echo ~)}"
DATA_HOME="${XDG_DATA_HOME:-$HOME/.local/share}"
HULK_DATA_HOME="${HULK_DATA_HOME:-$DATA_HOME/hulk}"

# create data home if not present to ensure realpath does not fail
mkdir -p "$HULK_DATA_HOME"

if [ "$(uname)" == "Darwin" ]; then
echo -n $(grealpath "$HULK_DATA_HOME")
else
Expand Down