Disable sacrificial lamb #1642
Merged
Disable sacrificial lamb #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThagonDuarte
added
the
rules:2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
The rule changes for 2025 make the sacrificial lamb strategy pretty much useless. Since the penalty for "Motion in standby" is now applied to the whole team, the concept of the sacrificial lamb does not work anymore.
Therefore we disable it, by simply setting our wait timers for the sacrificial lamb strategy to 0s.
Fixes #1613
ToDo / Known Issues
Ideas for Next Iterations (Not This PR)
How to Test