[Fix] Remove memory leaks in ArmoireActivity by ending infinite animations in onPause #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s when Activity is paused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On an orientation change, I noticed that LeakCanary was reporting Context memory leaks in
ArmoireActivity:Upon investigation, these leaks were coming from underlying views infinite animations maintaining
ArmoireActivity's Context after it was destroyed. Ending/cancelling these infinite animations inArmoireActivitysonPauseremoves these memory leaks, and animations still re-play on an orientation change. Here is a recording of an orientation change after these changes:Screen_recording_20250125_113422.mp4
my Habitica User-ID: caef89d8-3a3d-4d3b-a5ad-67cb0455a56e