Skip to content

🐛 Fix EndDatePicker selection range progress #5619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

balajis-qb
Copy link
Contributor

Close #5599

Description

As mentioned in the linked issue, one of my previous PRs #5503 is causing an issue in applying --in-selecting-range over the hovered days.

We by default pre-select a selected date on the other months also. As a result the same date on the other months will be programatically pre-selected (even-though we didn't hover or select) and we use the same state to know the date till we want to highlight. The same issue also exist for startDate picker also, when navigating to the previous months - as we pre-select the already selected dates for the other months. So, as a fix I undo my existing fix.

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

Undo the PR Hacker0x01#5503 as by default we preselect the selected date to other months also, as a result the linked PR will disturb the keyboard selection range
Copy link

codecov bot commented May 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.98%. Comparing base (6f0da37) to head (59c2054).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5619      +/-   ##
==========================================
- Coverage   96.98%   96.98%   -0.01%     
==========================================
  Files          30       30              
  Lines        3355     3354       -1     
  Branches     1416     1415       -1     
==========================================
- Hits         3254     3253       -1     
  Misses        101      101              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martijnrusschen martijnrusschen merged commit b616046 into Hacker0x01:main May 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8.3.0 broken --in-selecting-range
2 participants