Conversation
…nstructor` to simplify and consolidate service parameter and constructor resolution logic. Refactor and extract reusable methods `getCommandNames` and `collectMissingArgTypes` to simplify configuration and constructor argument handling logic. Refactor and consolidate shared logic for type providers, translation inspections, and utility methods. Refactor XML reference providers by extracting `getXmlTextValue` and `buildMethodStringReference` methods to simplify and consolidate shared logic. Refactor `TwigExtensionParser` by extracting `collectPhpFiles` method to simplify and reuse PHP file collection logic in filter parsing. Refactor controller line-marker logic by extracting reusable `addControllerLineMarker` method in `RouteHelper` and simplifying XML/YAML provider implementations. Extract reusable Twig component-tag detection logic into `TwigHtmlCompletionUtil` to simplify inspections. Extract shared logic into reusable parsing methods for arguments and options, simplifying `CommandToInvokableIntention` and `SymfonyCommandUtil`. Refactor service suggestion actions to extend `AbstractServiceSuggestIntentionAction` for shared logic consolidation and code simplification. Refactor quick-fix actions to extend `AbstractGuessTypoQuickFix` for shared logic consolidation and reusability. Refactor translation completion providers to consolidate shared logic into `getTranslatableMessageProvider`. Refactor Twig completion providers to consolidate duplicated logic into `IncompleteTagTemplateCompletionProvider`. Make `isTwigComponentClass` public and reuse it in `PhpAttributeCompletionContributor`. Extract `getStringInArrayPattern` method to simplify and reuse array string matching logic in Twig patterns. Refactor actions to extend `AbstractNewPhpClassAction` for better reusability and code simplification.
Haehnchen
force-pushed
the
feature/duplications
branch
from
3aaec1f to
b5faac6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.