Added quit warning if note is not saved#52
Open
R4H33M wants to merge 1 commit intoHaikuArchives:masterfrom
R4H33M:quit-warning
Open
Added quit warning if note is not saved#52R4H33M wants to merge 1 commit intoHaikuArchives:masterfrom R4H33M:quit-warning
R4H33M wants to merge 1 commit intoHaikuArchives:masterfrom
R4H33M:quit-warning
Conversation
Member
|
I checked this PR on 32bit Haiku. With gcc2 it works. With gcc8, clicking "Cancel" when the alert pops up to save a changed note on quitting will close the alert, but pop up a new one immediately. |
Member
|
@R4H33M can you send me an email at scottmc2 at gmail dot com |
Contributor
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #25
Fixes #13
Decided to just make a new PR on a fresh clone.
You might see some unrelated bugs due to #51, but from my testing this code seems to be working fine. I am still working on a fix for #51, but it seems to be one of those sneaky bugs.
I have yet to test on x86, though...