Implement ID3D12DeviceExt2 for cubin 64bit support #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding dxvk-nvapi PR is here: jp7677/dxvk-nvapi#276 (still quite WIP though) But I suppose this is now ready for review… cc: @liam-middlebrook |
Saancreed
commented
Feb 19, 2025
Comment on lines
+384
to
+392
| case D3D12_GET_CUDA_INDEPENDENT_DESCRIPTOR_OBJECT_SURFACE: | ||
| imageViewHandleInfo.descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_IMAGE; | ||
| break; | ||
| case D3D12_GET_CUDA_INDEPENDENT_DESCRIPTOR_OBJECT_TEXTURE: | ||
| FIXME("TEXTURE object type not supported.\n"); | ||
| return E_FAIL; | ||
| case D3D12_GET_CUDA_INDEPENDENT_DESCRIPTOR_OBJECT_SAMPLER: | ||
| imageViewHandleInfo.descriptorType = VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE; | ||
| break; |
There was a problem hiding this comment.
@liam-middlebrook I'd appreciate a closer look at this, maybe you'll have an idea how to handle the TEXTURE case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't quite see the advantage of
pNextjust yet over simply reusing NVAPI's own mechanism but maybe I'm too used to working with NVIDIA's APIs to know any better.Temporary marked as draft until I update dxvk-nvapi's side to match.