This repository has been archived by the owner on Mar 7, 2022. It is now read-only.
forked from hibernate/hibernate-orm
-
Notifications
You must be signed in to change notification settings - Fork 2
apply HanseMerkur patch #1
Open
sisivy
wants to merge
1
commit into
HanseMerkur:5.3.20.HMx
Choose a base branch
from
sisivy:5.3.20.HMx
base: 5.3.20.HMx
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmlr
reviewed
Jan 15, 2021
@@ -47,31 +51,34 @@ protected AbstractRelationQueryGenerator( | |||
|
|||
/** | |||
* @return Query executed to retrieve state of audited entity valid at previous revision | |||
* or removed during exactly specified revision number. Used only when traversing deleted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatierung bitte nicht ändern
chmlr
reviewed
Jan 15, 2021
} | ||
return query; | ||
} | ||
|
||
protected String queryToString(QueryBuilder query) { | ||
return queryToString( query, Collections.emptyMap() ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatierung bitte nicht ändern
chmlr
reviewed
Jan 15, 2021
} | ||
|
||
protected String queryToString(QueryBuilder query, Map<String, Object> queryParamValues) { | ||
final StringBuilder sb = new StringBuilder(); | ||
query.build( sb, queryParamValues ); | ||
query.build(sb, queryParamValues); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatierung bitte nicht ändern
chmlr
reviewed
Jan 15, 2021
@@ -348,6 +349,7 @@ public void testUnversionedRelation() { | |||
} | |||
|
|||
@Test | |||
@Ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warum? Kann der test nicht angepasst werden?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.