Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[design] 판별된 기사 목록 페이지 퍼블리싱 #18

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Conversation

rokaf6444
Copy link
Contributor

@rokaf6444 rokaf6444 commented Nov 20, 2024

변경 사항

판별된 기사 목록 페이지를 퍼블리싱했습니다.

  • 배경 색상 통일: 실패(엮인 CSS 부분이 많아서 리팩토링 필요), 이후 작업 진행 판단
  • Navbar 통일: 완료(Navbar.jsx 파일 사용)
  • CSS 충돌 해결: 3/4 완료, index.css → .module.css 실패(엮인 CSS 부분이 많아서 리팩토링 필요)
  • 코드 중 이미지 경로 수정 등 리팩토링 완료

라우팅 경로는 다음과 같습니다.
<Route path="/OnboardingPage" element={} />
<Route path="/IdentifiedArticlesPage" element={} />

테스트 실행

  • 👍 Yes
  • 🙅 No, Because they are not neaded
  • 🤯 No, Because I needed help with writing tests

테스트 결과

image
image

@rokaf6444 rokaf6444 requested a review from lsh1215 November 20, 2024 07:04
@rokaf6444 rokaf6444 self-assigned this Nov 20, 2024
@rokaf6444 rokaf6444 linked an issue Nov 20, 2024 that may be closed by this pull request
1 task
@rokaf6444 rokaf6444 added the design 디자인 퍼블리싱 label Nov 20, 2024
@rokaf6444 rokaf6444 requested a review from Wooniq November 21, 2024 08:00
@Wooniq Wooniq merged commit 1be0b45 into develop Nov 21, 2024
0 of 2 checks passed
@rokaf6444 rokaf6444 deleted the design/#10 branch November 25, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design 디자인 퍼블리싱
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[design] 판별된 기사 목록 페이지 퍼블리싱
2 participants