Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PublicLock V14 Eligibility #63

Merged
merged 22 commits into from
Sep 23, 2024
Merged

Conversation

spengrah
Copy link
Member

@spengrah spengrah commented Jul 3, 2024

This is a submission for a new module that creates a tight coupling between a hat and an Unlock Protocol key NFT.

The module is designed to serve as an eligibility module for the hat, as a hatter contract for one of the hat's admins, and as a UnlockProtocol hook. When deployed, the module creates a new lock contract. Whenever a key is purchased from that lock contract, it mints a corresponding hat.

TODO

  • finalize module contract
  • write module readme
  • deploy implementation(s)
  • update submission metadata based on finalized contract
  • add ABI to submission
  • finalize metadata

Copy link

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments!

modules/PublicLockV14EligibilityHatter.json Outdated Show resolved Hide resolved
modules/PublicLockV14EligibilityHatter.json Outdated Show resolved Hide resolved
@spengrah spengrah changed the base branch from submissions to test-optimizations September 14, 2024 14:37
Base automatically changed from test-optimizations to submissions September 16, 2024 13:12
@spengrah spengrah marked this pull request as ready for review September 17, 2024 14:03
@spengrah spengrah requested review from a team as code owners September 17, 2024 14:03
@gershido gershido self-requested a review September 17, 2024 20:26
Copy link
Contributor

@gershido gershido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@YamineRL YamineRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@spengrah spengrah merged commit 4212b61 into submissions Sep 23, 2024
2 checks passed
@scottrepreneur scottrepreneur deleted the add/unlock-eligibility branch January 20, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants