Identify modules by ID and version #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
client.getModuleById(id: string)function actually expects the module's implementation address, which makes it kind of redundant as far as I can tell, given that there's also aclient.getModuleByImplementation(address: Address)function.So, this PR updates the
getModuleById(id: string)function to accept the module's specific ID, as specified by theidparameter in themodules-registryrepository's published module metadatas (for example: https://github.com/Hats-Protocol/modules-registry/blob/4212b61f818515e544f23c2abfdfe6e48d4704ce/modules/haberdasher-labs_hats-election-eligibility_v0.2.0.json#L2)Now, since module names are not unique (it's valid and expected to have multiple versions for the same module id), I've also updated the
getModuleById(id: string)function's arity to also require aversionstring:getModuleById(id: string, version: string).Have updated all of the tests to account for these changes.