Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Don't disable controller when disabling logs #3457

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jan 21, 2024

When I implemented the option to disable logs, I copied the component used to disable the controller to have the boilerplate and I didn't remove a part of the code.

Because of that, when disabling/enabling logs, that was also enabling/disabling the controller flag.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 21, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team January 21, 2024 02:40
@arielj arielj merged commit fc212b9 into main Jan 21, 2024
9 checks passed
@arielj arielj deleted the fix-bug-disabling-controller-with-logs branch January 21, 2024 17:09
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants