[Fix] Windows development fixes #3458
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
HamsterExAstris
changed the title
HamsterExAstris
changed the title
arielj
reviewed
Jan 27, 2024
| @@ -29,7 +30,7 @@ describe('Utilities - Rest', () => { | |||
| expect(() => { | |||
| unlinkFile(__dirname) | |||
| }).toThrowError( | |||
| `Couldn't remove ${workDir}/src/backend/wine/manager/downloader/__tests__/utilities!` | |||
| `Couldn't remove ${workDir}${path.sep}src${path.sep}backend${path.sep}wine${path.sep}manager${path.sep}downloader${path.sep}__tests__${path.sep}utilities!` | |||
There was a problem hiding this comment.
we should use path.join here like path.join(workDir, 'src', 'backend', ...) instead interpolating path.sep, it's easier to read and should take care of using the right separator
There was a problem hiding this comment.
Thanks, that is much more readable!
HamsterExAstris
force-pushed
the
force_lf_checkout
branch
from
a7eddd3 to
a21c38f
Compare
flavioislima
reviewed
Apr 7, 2024
| unzipDir: installDir, | ||
| onProgress: progress | ||
| }) | ||
| ).resolves.toStrictEqual( | ||
| `Succesfully unzip ${workDir}/src/backend/wine/manager/downloader/__tests__/utilities/../test_data/test.tar.xz to ${workDir}/src/backend/wine/manager/downloader/__tests__/utilities/test_unzip.` | ||
| `Succesfully unzip ${path.join( |
There was a problem hiding this comment.
was this needed to fix the issue with the prettier as well?
seems unrelated.
|
Question: this supposed to fix the issue where when we try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prettier forces all files to have Unix (LF) line endings. When a Windows user has
core.autocrlfset to true in their global.gitconfig, commits use LF line endings but the files on disk use CRLF. This leads to spurious Prettier differences, causing the commit hook to fail.This overrides that global setting, using LF endings for text files on disk regardless of the
core.autocrlfsetting.It also fixes some tests that assumed Unix directory separators.
Use the following Checklist if you have changed something on the Backend or Frontend: