Fix: Remove sideloaded games from recent list when uninstalled

[arielj]

We have an issue that we can only manually remove elements from the recent list in the tray icon when they are either installed or part of the games in the library, but uninstalled sideloaded games disappear completely.

This PR doesn't fix the full problem but I think it's good enough for most use cases:

• It does remove the item when uninstalled
• It does NOT cleanup the list if it has old items (I don't think it's worth including code to check the list and remove entries, we can handle those cases manually)

To clean the list with already old elements, we can instruct users to edit the file at ~/.config/heroic/store/config.json and remove elements they don't want from the "recent" key.

Fixes #4170

---

Use the following Checklist if you have changed something on the Backend or Frontend:

• Tested the feature and it's working on a current and clean install.
• Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
• Created / Updated Tests (If necessary)
• Created / Updated documentation (If necessary)

[Etaash-mathamsetty]

could you add awaits and await removeNonSteamGame({ gameInfo }) as well ?

[arielj]

I understand we intentionally don't await for these things, they can happen async and makes it faster

[CommandMC]

Could still wrap 'em in an await Promise.all([ ... ]) to at least run them in parallel

[arielj]

aren't those already running in parallel? I think we really don't care about waiting for the result of those calls at all

is there any benefit I'm missing?

[Etaash-mathamsetty]

I thought it would be better if everything was removed by the time this function returned, but it's not necessary. Also the other uninstall functions use awaits

[flavioislima]

I dont think we need await there tbh, I agree with Ariel that this type of thing is fine to be async since it will take less than a second and should not block anything