Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Add support for wiki links in known fixes to display in game details page #4295

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jan 22, 2025

This PR adds support of adding a wiki page link in the known fixes repo so we can display it in the game page of a game to show the user there's known information they should read about that particular game.

image

This example is for Heroes of Might and Magic 3 Complete that (currently) needs a fix that we can't automate for the game to open, so we can point to the detail in our Wiki:

This way users can find out known solutions and workarounds without having to do the research or ask on discord.

Since Wiki pages can also be useful for Windows games (like the Bethesda games reg fix on Windows), I updated the code to download the known-fixes files also on Windows. There's no risk of the other fixes running on windows because they only run after a new prefix is created.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 22, 2025
@arielj arielj requested review from Etaash-mathamsetty, a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team January 22, 2025 03:44
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is useful 🔥

@arielj arielj force-pushed the wiki-link-known-fixes branch from 7731826 to 2a6bb11 Compare March 1, 2025 17:09
@flavioislima flavioislima merged commit 7279908 into main Mar 1, 2025
9 checks passed
@flavioislima flavioislima deleted the wiki-link-known-fixes branch March 1, 2025 17:15
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Mar 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants