Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Skip games that can only be installed on Android devices #4364

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Mar 1, 2025

With the new Epic mobile app, they are giving away mobile games like the do on PC, but those can't really be handled by legendary yet (fetching game info fails, and it shows no version in the logs).

So we should skip them from now to not show them in the library (it just crashes the install dialog and the details page)

Maybe in some future they can be installed but not yet.

Note that I only own an Android phone, I don't know how things look like for iOS devices so I don't have a fix for that

Fixes #4354


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 1, 2025
@arielj arielj requested review from Etaash-mathamsetty, a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team March 1, 2025 19:02
@flavioislima flavioislima merged commit 506a114 into main Mar 1, 2025
9 checks passed
@flavioislima flavioislima deleted the skip-epic-android-games branch March 1, 2025 19:17
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Mar 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
2 participants