Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Allow setting the Disable UMU default in General Settings > Game Defaults #4378

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Mar 3, 2025

This PR adds the Disable UMU setting in the defaults in general settings so it can be configured for all new games added instead of disabling it manually for each game if the user doesn't want to use umu at all.

This doesn't globally disable umu though, for games that are already installed it has to be manually disabled.

I also added some tests for the global config and game config to start adding tests for these things when we change defaults and that (it's not covering all settings and many cases, but it's a start)

Since it doesn't exactly disable UMU globally, it doesn't fully solve #4374, but I think it's good enough since the option to change the default value aligns more with how the other settings work.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 3, 2025
@arielj arielj requested review from Etaash-mathamsetty, a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team March 3, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant