update tests

Application/ResearchDataManagementPlatform/WindowManagement/HomePane/HomeUI.cs

@@ -81,8 +81,6 @@ protected override void OnLoad(EventArgs e)
 
     public void RefreshBus_RefreshObject(object sender, RefreshObjectEventArgs e)
     {
-
-        //todo what does this do?
-        //BuildCommandLists();
+        BuildCommandLists();
     }
 }

Rdmp.UI.Tests/CatalogueUITests.cs

@@ -26,7 +26,7 @@ public void Test_CatalogueUI_NormalState()
         Assert.That(cata.HasLocalChanges().Evaluation, Is.EqualTo(ChangeDescription.NoChanges));
 
         //but when I type text
-        ui._scintillaDescription.Text = "amagad zombies";
+        ui.tbDescription.Text = "amagad zombies";
 
         Assert.Multiple(() =>
         {
@@ -42,7 +42,7 @@ public void Test_CatalogueUI_NormalState()
         Assert.Multiple(() =>
         {
             //it should set the text editor back to blank
-            Assert.That(ui._scintillaDescription.Text, Is.EqualTo(""));
+            Assert.That(ui.tbDescription.Text, Is.EqualTo(""));
             //and clear my class property
             Assert.That(cata.Description, Is.EqualTo(null));
         });
@@ -51,22 +51,22 @@ public void Test_CatalogueUI_NormalState()
         saver.Redo();
         Assert.Multiple(() =>
         {
-            Assert.That(ui._scintillaDescription.Text, Is.EqualTo("amagad zombies"));
+            Assert.That(ui.tbDescription.Text, Is.EqualTo("amagad zombies"));
             Assert.That(cata.Description, Is.EqualTo("amagad zombies"));
         });
 
         //undo a redo should still be valid
         saver.Undo();
         Assert.Multiple(() =>
         {
-            Assert.That(ui._scintillaDescription.Text, Is.EqualTo(""));
+            Assert.That(ui.tbDescription.Text, Is.EqualTo(""));
             Assert.That(cata.Description, Is.EqualTo(null));
         });
 
         saver.Redo();
         Assert.Multiple(() =>
         {
-            Assert.That(ui._scintillaDescription.Text, Is.EqualTo("amagad zombies"));
+            Assert.That(ui.tbDescription.Text, Is.EqualTo("amagad zombies"));
             Assert.That(cata.Description, Is.EqualTo("amagad zombies"));
         });
 
@@ -113,9 +113,15 @@ public void Test_CatalogueUI_AcronymDuplicates()
 
         AssertNoErrors(ExpectedErrorType.Any);
 
+        //when I type the Acronym of another Catalogue
+        ui.tbAcronym.Text = "AB";
+
         //it tells me that I have to make it unique
         AssertErrorWasShown(ExpectedErrorType.ErrorProvider, "Must be unique");
 
+        //so I make it unique
+        ui.tbAcronym.Text = "ABC";
+
         //and all is good again
         AssertNoErrors(ExpectedErrorType.Any);
     }

Rdmp.UI/Collections/CatalogueCollectionUI.cs

@@ -38,8 +38,6 @@ namespace Rdmp.UI.Collections;
 /// 
 /// <para>Pressing the Del key will prompt you to delete the selected item.</para>
 /// 
-/// <para>By default Deprecated, Internal and ColdStorage Catalogues do not appear, you can turn visibility of these on by selecting the relevant tick boxes.</para>
-/// 
 /// <para>Finally you can launch 'Checking' for every dataset, this will attempt to verify the extraction SQL you
 /// have configured for each dataset and to ensure that it runs and that at least 1 row of data is returned.  Checking all the datasets can take a while so runs asynchronously.</para>
 /// </summary>

Rdmp.UI/Collections/DataExportCollectionUI.cs

@@ -126,10 +126,7 @@ public override void SetItemActivator(IActivateItems activator)
 
     public void RefreshBus_RefreshObject(object sender, RefreshObjectEventArgs e)
     {
-        if (e.Object.GetType() == typeof(Project))
-        {
             SetupToolStrip();
-        }
     }
 
     private void SetupToolStrip()

Rdmp.UI/Collections/FavouritesCollectionUI.cs

@@ -57,7 +57,6 @@ public override void SetItemActivator(IActivateItems activator)
 
     public void RefreshBus_RefreshObject(object sender, RefreshObjectEventArgs e)
     {
-        //maybe this?
         RefreshFavourites();
     }
 

Rdmp.UI/MainFormUITabs/CatalogueUI.cs

@@ -51,10 +51,6 @@ public CatalogueUI()
 
         AssociatedCollection = RDMPCollection.Catalogue;
 
-        //c_ddType.DataSource = Enum.GetValues(typeof(Catalogue.CatalogueType));
-        //c_ddPeriodicity.DataSource = Enum.GetValues(typeof(Catalogue.CataloguePeriodicity));
-        //c_ddGranularity.DataSource = Enum.GetValues(typeof(Catalogue.CatalogueGranularity));
-
         UseCommitSystem = true;
     }
 
@@ -340,6 +336,7 @@ private void tabControl1_SelectedIndexChanged(object sender, EventArgs e)
                 {
                     item.Visible = false;
                 }
+                Bind(tbAcronym, "Text", "Acronym", c => c.Acronym);
                 Bind(tbAbstract, "Text", "ShortDescription", c => c.ShortDescription);
                 Bind(tbDescription, "Text", "Description", c => c.Description);
                 foreach (Control item in tabPage1.Controls)

Rdmp.UI/SimpleControls/MultiSelectChips/Chip.cs

@@ -44,27 +44,10 @@ public int Radius
         private static extern IntPtr CreateRoundRectRgn(int nLeftRect, int nTopRect,
             int nRightRect, int nBottomRect, int nWidthEllipse, int nHeightEllipse);
 
-        private GraphicsPath GetRoundRectagle(Rectangle bounds, int radius)
-        {
-            float r = radius;
-            GraphicsPath path = new GraphicsPath();
-            path.StartFigure();
-            path.AddArc(bounds.Left, bounds.Top, r, r, 180, 90);
-            path.AddArc(bounds.Right - r, bounds.Top, r, r, 270, 90);
-            path.AddArc(bounds.Right - r, bounds.Bottom - r, r, r, 0, 90);
-            path.AddArc(bounds.Left, bounds.Bottom - r, r, r, 90, 90);
-            path.CloseFigure();
-            return path;
-        }
-
         private void RecreateRegion()
         {
             var bounds = ClientRectangle;
 
-            //using (var path = GetRoundRectagle(bounds, this.Radius))
-            //    this.Region = new Region(path);
-
-            //Better round rectangle
             this.Region = Region.FromHrgn(CreateRoundRectRgn(bounds.Left, bounds.Top,
                 bounds.Right, bounds.Bottom, Radius, radius));
             this.Invalidate();