Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix simple file extractor check error #2109

Merged
merged 2 commits into from
Jan 13, 2025
Merged

fix simple file extractor check error #2109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ca302c
fix simple file extractor
JFriel Jan 10, 2025
974b7af
fix white space
JFriel Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Build on and target .Net 9 rather than 8
- Simplify DB Patching Interface
- Fix issue with Simple File Extractor pipeline component checking

## [8.4.2] - 2024-12-18

Expand Down
11 changes: 0 additions & 11 deletions Rdmp.Core/DataExport/DataExtraction/Pipeline/SimpleFileExtractor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,17 +72,6 @@ public override void Check(ICheckNotifier notifier)
notifier.OnCheckPerformed(new CheckEventArgs(
$"PerPatient is false but Pattern {Pattern} contains token $p. This token will never be matched in MoveAll mode",
CheckResult.Fail));

try
{
notifier.OnCheckPerformed(new CheckEventArgs($"Output path is:{GetDestinationDirectory()}",
CheckResult.Success));
}
catch (Exception ex)
{
throw new Exception(
"Unable to to determine output directory from 'OutputDirectoryName'. Perhaps pattern is bad", ex);
}
}

protected override void MoveFiles(ExtractGlobalsCommand command, IDataLoadEventListener listener,
Expand Down
Loading