Skip to content

Conversation

BryanCazabonne
Copy link
Member

No description provided.

…Field}DetectorBasedEventState for event time handling.
@BryanCazabonne
Copy link
Member Author

BryanCazabonne commented Sep 2, 2025

Pipeline is red because of code duplication not related to this pull request.
Unit tests are green 🟢

@BryanCazabonne BryanCazabonne self-assigned this Sep 2, 2025
Copy link
Contributor

@Serrof Serrof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done on building a numerical example reproducing the issue

One last remark: it'd be good to use final wherever possible

@BryanCazabonne
Copy link
Member Author

Thank you for the review. Comments were taken into account. I merge the branch

@BryanCazabonne BryanCazabonne merged commit 0f36014 into patch-4.0.2 Sep 3, 2025
1 check failed
@BryanCazabonne BryanCazabonne deleted the orekit-issue-1808 branch September 3, 2025 07:27
BryanCazabonne added a commit that referenced this pull request Sep 8, 2025
…Field}DetectorBasedEventState for event time handling. (#417)

Fixes #416
BryanCazabonne added a commit that referenced this pull request Sep 8, 2025
…Field}DetectorBasedEventState for event time handling. (#417)

Fixes #416
BryanCazabonne added a commit that referenced this pull request Sep 8, 2025
…Field}DetectorBasedEventState for event time handling. (#417)

Fixes #416
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants