Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: make ubuntu 24.04 the latest version #19221

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

linux: make ubuntu 24.04 the latest version #19221

wants to merge 1 commit into from

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Feb 3, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

MikeMcQuaid
MikeMcQuaid approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@carlocab
Copy link
Member

carlocab commented Feb 3, 2025

We should update the glibc formula first.

@iMichka
Copy link
Member Author

iMichka commented Feb 4, 2025

Here it is: #206533

I think we will need to ship a separate PR in homebrew/brew for LINUX_GLIBC_NEXT_CI_VERSION and set it to 2.39, see https://github.com/Homebrew/brew/pull/19221/files#diff-d732b2f83910341061a6ca3b9bc03c30e10bfb6c7d5aa04cb999f731d7c5e752L51

@iMichka
Copy link
Member Author

iMichka commented Feb 4, 2025

I made the separate PR for the next glibc version, that should be merged first: #19238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iMichka @carlocab @MikeMcQuaid