Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

badgeify 1.5.4 (new cask) #201673

Merged
merged 1 commit into from
Feb 14, 2025
Merged

badgeify 1.5.4 (new cask) #201673

merged 1 commit into from
Feb 14, 2025

Conversation

ahonn
Copy link
Contributor

@ahonn ahonn commented Feb 14, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Casks/b/badgeify.rb Outdated Show resolved Hide resolved
@ahonn ahonn requested a review from daeho-ro February 14, 2025 08:34
Casks/b/badgeify.rb Outdated Show resolved Hide resolved
@ahonn ahonn requested a review from khipp February 14, 2025 08:46
@khipp
Copy link
Member

khipp commented Feb 14, 2025

Thank you, @ahonn! Please also try to squash your commits.

@khipp khipp changed the title badgeify 1.5.3 (new cask) badgeify 1.5.4 (new cask) Feb 14, 2025
@ahonn
Copy link
Contributor Author

ahonn commented Feb 14, 2025

Thank you, @ahonn! Please also try to squash your commits.

done, thank you for your review

Copy link
Member

@khipp khipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution to homebrew-cask, @ahonn! 🎉

@daeho-ro daeho-ro merged commit fd0d35b into Homebrew:master Feb 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants