Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
We were using a stale variable for a nullability comparison.
test here: [no-release-notes] test for left join bug dolthub/go-mysql-server#2840
deleteErr
message in returned erroruser
andpassword
options for sql-serverThe
--user
and--password
options to sql-server (whether specified on the command line or in a configuration file) allow users to specify an ephemeral superuser to use for the life of the sql-server process. This is a convenient way to temporarily create a superuser, but has several edge cases that can cause unexpected behavior.This change removes support for the
--user
and--password
options and instead customers should now explicitly create that user using standard SQL statements for managing users, such as:user
orpassword
is specified in a config file, the sql-server will still startup, but will log a warning. If--user
or--password
is specified as a CLI argument the sql-server will error out with an error message explaining the change. The reason for the difference in handling is that it may be harder for customers to update config files.This PR avoids loading dolt DBs at startup, instead waiting for either
DoltEnv.ReloadDB
orMultiRepoEnv.ReloadDBs
to be called.Based on the specific subcommand being run:
MultiRepoEnv.ReloadDBs
is called prior to command execution if the command will always need DB access.DoltEnv.ReloadDB
Commands that make use of
CliContext
don't need to load the DB, as the underlying query engine will load the DB if it needs database access. As a result, commands that are implemented purely in terms of theCliContext
will load the DB when Dolt is runnning an embedded SQL engine, and will skip loading the DB when Dolt is connecting to a running server.Before this change, the code that iterates over journal records would silently stop processing journal records once it encountered any invalid record. This change turns those invalid records into errors so that data isn't silently ignored. Customers can opt-in to the previous behavior by setting the
DOLT_SKIP_INVALID_JOURNAL_RECORDS
environment variable to any value.go-mysql-server
This adds the concept of an interpreter expression, which is primarily used by integrators.
This PR moves the logic for
validateStoredProcedure
analyzer rule into the planbuilder, allowing for proper error messages.Related: Stored procedure: temp table created in procedure not visible dolthub/dolt#8762
Closed Issues