Seminar7 #6
Open
Seminar7 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papajj06
reviewed
Jun 12, 2022
| app:layout_constraintTop_toTopOf="parent" /> | ||
|
|
||
| <TextView | ||
| android:id="@+id/textView" |
Comment on lines
31
to
35
| val intent = Intent(context,SignInActivity::class.java) | ||
| startActivity(intent) | ||
| activity?.finish() | ||
| } | ||
| } |
hansh0101
reviewed
Jun 14, 2022
| binding.btnNext.setOnClickListener { | ||
| val intent = Intent(context, SignInActivity::class.java) | ||
| startActivity(intent) | ||
| activity?.finish() |
There was a problem hiding this comment.
activity보다는 저는 requireActivity()를 즐겨 씁니다. 이전에 이런 글을 봤는데, requireActivity()가 더 명시적인 예외를 발생시킨다고 하네요.
Comment on lines
25
to
26
| val intent = Intent(this, SignInActivity::class.java) | ||
| startActivity(intent) |
There was a problem hiding this comment.
이렇게 구현하면 로그아웃을 하고 로그인 Activity를 열게 될 것입니다. 그런데 문제가 생길 수 있습니다. 로그인 화면으로 이동한 뒤 뒤로가기 버튼을 누르면 어떻게 될까요?
Comment on lines
+65
to
+82
| fun <ResponseType> Call<ResponseType>.enqueueUtil( | ||
| onSuccess: (ResponseType) -> Unit, | ||
| onError: ((stateCode: Int) -> Unit)? = null | ||
| ) { | ||
| this.enqueue(object : Callback<ResponseType> { | ||
| override fun onResponse(call: Call<ResponseType>, response: Response<ResponseType>) { | ||
| if (response.isSuccessful) { | ||
| onSuccess.invoke(response.body() ?: return) | ||
| } else { | ||
| onError?.invoke(response.code()) | ||
| } | ||
| } | ||
|
|
||
| override fun onFailure(call: Call<ResponseType>, t: Throwable) { | ||
| Log.d("NetworkTest", "error: $t") | ||
| } | ||
| }) | ||
| } |
There was a problem hiding this comment.
다른 YB들 코드리뷰에서도 이야기하긴 했는데, 이 확장함수(Retrofit Call에 대한 확장함수)는 이 Activity에서만 쓰이는게 아니잖아요? 그래서 따로 파일에 구현을 빼놔도 좋을 것 같습니다.
settingactivity에서 뒤로가기 했을 때 종료되는거 수정함
hansh0101
reviewed
Jun 15, 2022
| @@ -23,6 +24,7 @@ class SettingActivity : AppCompatActivity() { | |||
| LOGINSharedPreferences.setLogin(this) | |||
| Toast.makeText(this, "자동로그인이 해제되었습니다.", Toast.LENGTH_SHORT).show() | |||
| val intent = Intent(this, SignInActivity::class.java) | |||
| finishAffinity() | |||
There was a problem hiding this comment.
오 최근에 이런 코드를 짰어야해서 찾아보고 짜긴 했는데 이런 메서드는 처음 보네요 저도 한 수 배워갑니다. 👍
uxri
approved these changes
Aug 12, 2022
| @@ -39,6 +39,9 @@ dependencies { | |||
| implementation "com.squareup.retrofit2:converter-gson:2.9.0" | |||
| implementation "com.google.code.gson:gson:2.8.6" | |||
|
|
|||
| implementation 'androidx.navigation:navigation-fragment-ktx:2.4.2' | |||
| implementation 'androidx.navigation:navigation-ui-ktx:2.4.2' | |||
| import com.example.num1.view.activity.HomeActivity | ||
| import com.example.num1.view.activity.SignInActivity | ||
|
|
||
| class SettingActivity : AppCompatActivity() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.