Skip to content

allow custom HDF5 data types in h5createDataset and h5writeDataset#130

Open
ilia-kats wants to merge 1 commit into
Huber-group-EMBL:develfrom
ilia-kats:customtypes
Open

allow custom HDF5 data types in h5createDataset and h5writeDataset#130
ilia-kats wants to merge 1 commit into
Huber-group-EMBL:develfrom
ilia-kats:customtypes

Conversation

@ilia-kats

Copy link
Copy Markdown
Contributor

This useful when one has a custom type, but still wants to use the default HDF5 spaces, DCPLs etc. that these functions provide. For example, when writing logical vectors that are compatible with Python's h5py, one needs to create a custom enum type with H5Tenum_create.

@ilia-kats

Copy link
Copy Markdown
Contributor Author

AFAICT the CI is failing somewhere in the testthat package itself, not due to my changes.

@codecov

codecov Bot commented Oct 12, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (e2e4ef7) 79.03% compared to head (f32940d) 78.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #130      +/-   ##
==========================================
- Coverage   79.03%   78.70%   -0.34%     
==========================================
  Files          36       36              
  Lines        1994     2005      +11     
==========================================
+ Hits         1576     1578       +2     
- Misses        418      427       +9     
Files Coverage Δ
R/h5create.R 83.14% <40.00%> (-1.34%) ⬇️
R/h5write.R 81.04% <57.14%> (-3.21%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant