Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial fix for #92 #93

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Conversation

apdavison
Copy link
Member

Partially fixes the problem with reverse links described in #92.

The remaining broken cases are where some forward links to the same type have singular names and others plural.

Running builder/update_openminds.py gives

Multiple forward link names found: {'specifications', 'specification'}, using specification
Multiple forward link names found: {'digitalIdentifier', 'digitalIdentifiers'}, using digitalIdentifier
Multiple forward link names found: {'formats', 'format'}, using format
Multiple forward link names found: {'licenses', 'license'}, using license
Multiple forward link names found: {'specifications', 'specification'}, using specification
Multiple forward link names found: {'dataLocations', 'dataLocation'}, using dataLocation
Multiple forward link names found: {'origins', 'origin'}, using origin
Multiple forward link names found: {'ageCategories', 'ageCategory'}, using ageCategories
Multiple forward link names found: {'preparationDesigns', 'preparationDesign'}, using preparationDesign
Multiple forward link names found: {'origins', 'origin'}, using origin
Multiple forward link names found: {'origins', 'origin'}, using origin
Multiple forward link names found: {'biologicalSexes', 'biologicalSex'}, using biologicalSex
Multiple forward link names found: {'type', 'types'}, using type

The remaining broken cases are where some forward links to the same type have singular names and others plural.

Running builder/update_openminds.py gives
```
Multiple forward link names found: {'specifications', 'specification'}, using specification
Multiple forward link names found: {'digitalIdentifier', 'digitalIdentifiers'}, using digitalIdentifier
Multiple forward link names found: {'formats', 'format'}, using format
Multiple forward link names found: {'licenses', 'license'}, using license
Multiple forward link names found: {'specifications', 'specification'}, using specification
Multiple forward link names found: {'dataLocations', 'dataLocation'}, using dataLocation
Multiple forward link names found: {'origins', 'origin'}, using origin
Multiple forward link names found: {'ageCategories', 'ageCategory'}, using ageCategories
Multiple forward link names found: {'preparationDesigns', 'preparationDesign'}, using preparationDesign
Multiple forward link names found: {'origins', 'origin'}, using origin
Multiple forward link names found: {'origins', 'origin'}, using origin
Multiple forward link names found: {'biologicalSexes', 'biologicalSex'}, using biologicalSex
Multiple forward link names found: {'type', 'types'}, using type
```
@apdavison apdavison merged commit 4a28982 into HumanBrainProject:master Sep 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant