Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize using GAN #16

Merged
merged 57 commits into from
Nov 8, 2022
Merged

Visualize using GAN #16

merged 57 commits into from
Nov 8, 2022

Conversation

dfilan
Copy link
Collaborator

@dfilan dfilan commented Nov 7, 2022

Modify interpret.py to support visualizing input in the space of a trained generator's outputs.

Tested by running interpret.py to see if it ran without error (plus pre-commit hooks).

@dfilan dfilan requested a review from PavelCz November 7, 2022 22:15
Copy link
Member

@PavelCz PavelCz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Glad things are converging.
LGTM

if isinstance(img, tuple):
img_obs = img[0]
img_next_obs = img[1]
# TODO(df): check if I have to dump between these
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: You can record as much as you want and then dump at the end (as long as you don't dump the same key multiple times, of course.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just go ahead and merge, as we discussed, since I didn't find any problems. I'll just remove this todo if I successfully run interpret with wandb myself.

@PavelCz PavelCz merged commit f501e9e into main Nov 8, 2022
@dfilan dfilan deleted the add_generator branch November 8, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants