Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: Update installation instructions #652

Merged
merged 2 commits into from
Feb 12, 2025
Merged

readme: Update installation instructions #652

merged 2 commits into from
Feb 12, 2025

Conversation

Bjwebb
Copy link
Contributor

@Bjwebb Bjwebb commented Feb 6, 2025

@Bjwebb Bjwebb requested a review from simon-20 February 6, 2025 13:44
@Bjwebb Bjwebb force-pushed the 650-update-readme branch from 9b87caa to b2dcc28 Compare February 6, 2025 16:03
@simon-20
Copy link

simon-20 commented Feb 6, 2025

I can now get all the steps to run, and the webserver starts up without problems.

I've so far noticed two problems:

  1. The images don't display. For example, the path for the graph of total activities in the HTML is /generated/img/aggregate/activities.png. On disk, the path (relative to the root of the git repo) is ./out/img/aggregate/activities.png

  2. The JSON links are broken. For instance, when trying to access the following URL:

http://localhost:8000/stats/gitaggregate-dated/unique_identifiers.json

This is stored on disk, relative to the root of git repo in,

./stats-calculated/gitaggregate-dated/

But the HTTP request is trying to access that file one folder up, i.e., it's trying to access:

/home/my-user/dev/stats-calculated/gitaggregate-dated/unique_identifiers.json

when it should be accessing:

/home/my-user/dev/IATI-Dashboard/stats-calculated/gitaggregate-dated/unique_identifiers.json

@Bjwebb
Copy link
Contributor Author

Bjwebb commented Feb 11, 2025

@simon-20 This should now work as expected.

@Bjwebb Bjwebb merged commit af26534 into develop Feb 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants