CSI-2625 add CSI IBM Driver operator CI #189
Conversation
matancarmeli7
changed the title
matancarmeli7
requested review from
ArbelNathan,
oriyarde,
zingero,
barakda,
annaparienti,
roysahar-ibm and
tyichye19
Signed-off-by: matancarmeli7 <[email protected]>
Signed-off-by: matancarmeli7 <[email protected]>
Signed-off-by: matancarmeli7 <[email protected]>
Signed-off-by: matancarmeli7 <[email protected]>
build/ci/github_actions/driver/get_driver_images_tag_from_branch.sh
Outdated
Show resolved
Hide resolved
| export driver_image_inspect=`docker manifest inspect $csiblock_docker_registry_username/ibm-block-csi-$driver_component:$target_specific_tag` | ||
| if [[ "$driver_image_inspect" != "" ]]; then | ||
| is_image_tag_exists=true | ||
| fi | ||
| echo $is_image_tag_exists |
There was a problem hiding this comment.
consider using a shorter command with /dev/null and just checking the exit status
There was a problem hiding this comment.
sorry for the confusion, I think the status check should remain inside the function, to keep it "boolean" as before.
I just wanted to avoid keeping the entire command output in a variable
There was a problem hiding this comment.
do you mean move those lines into is_private_branch_component_image_exists function?
There was a problem hiding this comment.
no, I mean restore the function to how it was before (echoing true/false), but according to $? == "0", so the caller would continue to compare using == "true"
build/ci/github_actions/driver/get_driver_images_tag_from_branch.sh
Outdated
Show resolved
Hide resolved
Signed-off-by: matancarmeli7 <[email protected]>
Signed-off-by: matancarmeli7 <[email protected]>
Signed-off-by: matancarmeli7 <[email protected]>
Signed-off-by: matancarmeli7 <[email protected]>
Signed-off-by: matancarmeli7 <[email protected]>
| driver_component=$1 | ||
| image_to_check=$csiblock_docker_registry_username/ibm-block-csi-$driver_component:$branch_image_tag | ||
| is_image_tag_exists=false | ||
| export driver_image_inspect=$(docker manifest inspect $image_to_check &> /dev/null; echo $?) |
There was a problem hiding this comment.
where is driver_image_inspect used?
why does it sound like an action? if I understand correctly, it is not a function
| - name: Login to DockerHub | ||
| uses: docker/login-action@v1 | ||
| with: | ||
| username: '${{ secrets.CSIBLOCK_DOCKER_REGISTRY_USERNAME }}' |
There was a problem hiding this comment.
I would avoid using the current registry/user name (csiblock) in our variables, since it can always change in the future
| - name: Deploy ibm block csi operator | ||
| run: | | ||
| build/ci/github_actions/operator/deploy_operator.sh | ||
| - name: Deploy ibm block csi driver |
There was a problem hiding this comment.
why is this under create_cluster?
Signed-off-by: matancarmeli7 <[email protected]>
No description provided.