Fix file extension during file source orbit rename #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Irfan Sharif <[email protected]>
edmundreinhardt
requested changes
Jan 24, 2024
| if (error) { | ||
| console.error(`Error fixing extension's case for file: ${fileDir}`); | ||
| } else { | ||
| console.log(`File ${fileDir} renamed successfully to ${newFileName}`); |
There was a problem hiding this comment.
This is really an internal issue that we didn't get the case right the first time, so I don't think we should issue a consule statement here.
In fact, couldn't this be fixed at the time we do the initial rename? won't the console log have the wrong case there?
Signed-off-by: Irfan Sharif <[email protected]>
edmundreinhardt
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.