Improved the Climatic > PICSA > Crops Dialog Layout #9407
Conversation
|
@MeSophie well done. That's looking great.
And a question for you, to consider in both English and French. I think it would still be clear is we changed those labels into single words - and then we could save more space. Would they still be reasonably clear - and remember we will soon have the Help information as well, if needed! Could they be Planting, Amounts and Length? I fully understand that changing the labels will be in a second pull request. I like this separation of the tasks, We could also add tooltips e.g. Planting: The day number for planting. Starting from January, April 1st is day 92. Starting from July, November 1st is day 124. |
|
@rdstern Could you please describe this part in more detail? How are we going to implement it in the code? I tried replacing planting day with ‘April 1st’ and got an error apparently it doesn't take strings? |
|
@MeSophie I wonder if you have added tooltips to a dialog before? If not, then have a look at the calculator, almost any keyboard, that has many tooltips. Or was that not the question? |
|
@rdstern This PR is ready to be test. Please have a look. |
There was a problem hiding this comment.
@MeSophie this looks great - well done indeed. @lilyclements may like to look too, but I am approving anyway, so that could wait until it is merged.
@N-thony this would be very good to try and include in the new version this week.
instat/dlgPICSACrops.vb
Outdated
| @@ -23,6 +25,11 @@ Public Class dlgPICSACrops | |||
| Public bFirstLoad As Boolean = True | |||
| Private bReset As Boolean = True | |||
| Private strCurrDataName As String = "" | |||
| Private lstEndReceivers As New List(Of ucrReceiverSingle) | |||
| Private lstStartReceivers As New List(Of ucrReceiverSingle) | |||
| Private isFilling As Boolean = False | |||
There was a problem hiding this comment.
Our naming convention for boolean variables starts with a lowercase 'b', e.g., bIsFilling.
instat/dlgPICSACrops.vb
Outdated
| ucrReceiverYear.SetRCode(clsCropsFunction, bReset) | ||
| ucrReceiverStation.SetRCode(clsCropsFunction, bReset) | ||
| ucrReceiverRainfall.SetRCode(clsCropsFunction, bReset) | ||
| ucrReceiverDay.SetRCode(clsCropsFunction, bReset) | ||
| 'ucrReceiverStart.SetMeAsReceiver() | ||
| ucrSelectorForCrops.SetDataframe(ucrReceiverStart.GetDataName()) | ||
| ' ucrSelectorForCrops.SetDataframe(ucrReceiverStart.GetDataName()) |
instat/dlgPICSACrops.vb
Outdated
| @@ -218,15 +249,16 @@ Public Class dlgPICSACrops | |||
| 'TODO This should be done further done. | |||
| ' This ensures the correct data frame is set before attempting to fill the receiver | |||
| 'ucrReceiverYear.SetMeAsReceiver() | |||
| ucrSelectorForCrops.SetDataframe(ucrReceiverYear.GetDataName()) | |||
| 'ucrSelectorForCrops.SetDataframe(ucrReceiverYear.GetDataName()) | |||
Fixes #9384
@rdstern @N-thony I improved the PICSA > Crops dialog layout By adding a second selector. I will finalize the label change for the first selector on another PR because the change is on the data base. Please have a look.