Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing titles and themes in presentation table #9420

Closed

Conversation

Fidel365
Copy link
Contributor

@Fidel365 Fidel365 commented Feb 5, 2025

Fixes partially #9323,
@rdstern , @derekagorhom , @berylwaswa I made this mainly for syncing the data between the dialog and sub dialog all should work except for the style button.

@Fidel365
Copy link
Contributor Author

Fidel365 commented Feb 5, 2025

@rdstern currently throws an exception , but it works, I'm working around it.

@Fidel365
Copy link
Contributor Author

Fidel365 commented Feb 5, 2025

@rdstern this now works and it's ready, I have @derekagorhom recent changes here too!
Changes made in the title style, title text box and footnote textbox reflect to the subdialog and vice versa

@rdstern
Copy link
Collaborator

rdstern commented Feb 6, 2025

@Fidel365 it is almost there. But:
a) I changed the style and all seems to work. But when I returned and clicked on Style again, I got:

image

b) And I included a footnote each time. The first run it ignored the presence of the footnote completely. So there was no 1 in the title and no footnote. Now there is the 1 in the title correctly and the corresponding 1 in the footnote - but there is no footnote contents.

image

@Fidel365
Copy link
Contributor Author

Fidel365 commented Feb 6, 2025

@rdstern currently having a look at b, but a seems to be an issue even without these changes, not only is the above control with the issue, but also look what I got on the same using the master branch;
Screenshot (30)
I will have a look at it

@rdstern
Copy link
Collaborator

rdstern commented Feb 6, 2025

@Fidel365 that's important and useful to ask @Patowhiz .

But I think the master branch does show footnotes for the Titles doesn't it?

@Fidel365 Fidel365 closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants