Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade getPass to 0.2-2 to ensure compatibility #9432

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

N-thony
Copy link
Collaborator

@N-thony N-thony commented Feb 10, 2025

@ChrisMarsh82, I have made the changes here as discussed, have a look. If, this is merged I will create a test version and check if this issue is resolved.

I have also reported the issue on their GitHub wrathematics/getPass#20

@rdstern
Copy link
Collaborator

rdstern commented Feb 10, 2025

@N-thony thanks for continuing with this. It is really important that we can use Patrick's importing from Climsoft into R-Instat.
You may want to include @Patowhiz in the tests, so that he can check also that his feature of being able to read from the Initial as well as the Final table, is working.

When @jkmusyoka was in Zimbabwe recently, the reading from Initial wasn't working. But he was using an older version of R-Instat (because reading from Final was n't working in Version 0.8.0, or 0.8.1). So it is possible that reading from Initial works fine in the new version.

@Patowhiz MSD may have solved this issue before you arrive. If not, now that I hope everyone is agreed that the Final table is not final, I assume that one solution is to quickly transfer everything there. We now know the quality control is pretty feeble, so maybe do it after putting all the data together?

@N-thony N-thony merged commit 0f53692 into IDEMSInternational:master Feb 10, 2025
2 checks passed
@Patowhiz
Copy link
Contributor

Great that this has been solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants