Improvements to metadata window and hiding open refine dialog #9435
Conversation
instat/frmMain.vb
Outdated
| Private Sub ClearAllPanels() | ||
| splDataOutput.Panel1.Controls.Clear() | ||
| splMetadata.Panel1.Controls.Clear() | ||
| splExtraWindows.Panel2.Controls.Clear() | ||
| End Sub |
There was a problem hiding this comment.
I don't think you need this sub
There was a problem hiding this comment.
When swapping data and column metadata, then data with dataframe metadata or script, it seems to be stuck on the previous window, so, I need to clear it everytime I select a different option.
|
@Fidel365, when I have all the windows visible, and click on |
|
@rdstern I had power issues throughout today and yesterday as fiber cables are being installed in our area, but I ussually have stable power at night, I'm going to tidy this up tonight and hopefully tomorrow I will be back working to.normal hours. |
| @@ -1185,7 +1221,7 @@ Public Class frmMain | |||
| Dim strCurrentStatus As String | |||
|
|
|||
| strCurrentStatus = tstatus.Text | |||
| If clsRLink.bInstatObjectExists AndAlso ucrDataViewer.HasDataChanged Then | |||
There was a problem hiding this comment.
any reason for removing this code AndAlso ucrDataViewer.HasDataChanged?
This flag is used to trigger the autosaving when the data has changed. removing it means we are back to autosaving anytime even if the data hasn't changed.
| Private Sub ClearAllPanels() | ||
| ' splDataOutput.Panel1.Controls.Clear() | ||
| splMetadata.Panel1.Controls.Clear() | ||
| splMetadata.Panel2.Controls.Clear() | ||
| splExtraWindows.Panel2.Controls.Clear() | ||
| End Sub |
There was a problem hiding this comment.
I have tried without this sub, and it works fine, I still believe you don't need it.
| 'UpdateSwapDataAndScript() | ||
| 'UpdateSwapDataAndMetadata() | ||
| 'UpdateSwapDataFrameAndMetadata() |
| 'UpdateSwapDataAndScript() | ||
| 'UpdateSwapDataAndMetadata() | ||
| 'UpdateSwapDataFrameAndMetadata() |
|
@N-thony I assume this can be closed? |
Fixes issue partly issues #9374, #9368, #9383
Replaces pr #9390
@rdstern this is ready for review
@N-thony pr #9393 was dealing with resetting the window that I already did, unless it had other changes