Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the Find-replace dialog #9437

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

Vitalis95
Copy link
Contributor

Fixes #9326
@rdstern @N-thony , the PR sets items to NA

@rdstern
Copy link
Collaborator

rdstern commented Feb 12, 2025

@Vitalis95 this already seems to work. Just 2 points:
a) Could you change the Replace NA into From NA
b) The other buttone have lost the Pattern control, e.g.

image

@Vitalis95
Copy link
Contributor Author

@rdstern , I have sorted out now

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vitalis95 very nice.
@N-thony over to you to check and merge.
This is only small, but important for R-Instat. I want to minimise the things that should be simple - and they are for R-whizzes. But they can be frustrating for R-Instat users!

@N-thony N-thony merged commit 8b1dc02 into IDEMSInternational:master Feb 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the text find-replace dialog, also setting items to NA?
3 participants