-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving the Prepare > Column: Text > Split dialog #9477
Conversation
@Vitalis95 I note the bug is still there, namely that it produces just the 2 variables (not the three as is needed in the example I used. I think that is maybe a @lilyclements fix, as it was working ok in Version 0.8.2. I would still like the space( ) option to work as before - where (if there are say 3 spaces) it gives one extra variable per space. There are occasions where that might be useful. Incidentally I am also hoping you will add the spaces( ) option into the Paste New dialog. There is will not give options on the separator, and it will use the squash code. So it is just a checkbox to split on the multiple spaces option. |
@rdstern , update |
@rdstern , added Space Separated control to Paste New dialog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vitalis95 this is now very nice indeed. I was about to approve but I note you have also added the checkbox in the Paste New dialog.
It is working better than I thought possible, so I am very happy about this feature too. The way I suggested - with Split, would not have split the variable names.
I note that (like the tables dialogs) Ok needs to be pressed to make the multiple columns.
I tried with Ok and Keep, but then you have to refresh the display, and there is a button for this. That seems to be done when the dialog is re-opened, so perhaps that could be included after the Ok and keep too?
The one item to correct - I think - is that the Space Separated is usually only applicable when there is a single variable. So, when more than 1 column is pasted, thenit is unticked and disabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vitalis95 this looks great now.
@N-thony there are 3 main changes:
a) The bug in the split is resolved
b) There is an extra option in split when there can be multiple spaces between items.
c) There is a great additional checkbox in the Edit > Paste New to split items when there are spaces.
Really nice. Over to you to check.
Fixes partly #9464
@rdstern @N-thony , the pr removes extra spaces and ensure proper splitting