Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding package name to prevent error in Describe Two Variables #9482

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lilyclements
Copy link
Contributor

@lilyclements lilyclements commented Mar 6, 2025

Fixes #9481

@rdstern this is ready to review

@N-thony
Copy link
Collaborator

N-thony commented Mar 6, 2025

@rdstern @lilyclements, I got a similar problem in Describe > Tables > Summaris Dialogue with arrange() function from dplyr. I noticed this is due to the fact that we have removed as part of pre-loaded packages.
Also, count_label is missing in the current version
image
but it is there in 0.8.2
image

@rdstern
Copy link
Collaborator

rdstern commented Mar 6, 2025

@lilyclements and @N-thony I report on how I am now testing, using the new branches - my runs with version 1.0.0.
a) I used sessionInfo() to find which versions of the packages were attached.
b) I checked with the Tools > Add Packages and it said that all 4 packages need be iupdated.
c) I detached them in turn and found that Extras and databook still needed updating, but it said the other 2 were up-to-date.
d) I updated Extras and databook, from the existing dialog, and it worked fine. So now said all packages are up to date.
By the way it keeps saying databook is version 0.1.5?
Calculations is 0.1.3 and the others are 0.2.2.

Now to the check. I report, in passing, an odd problem with the survey data that the One Variable Summarise and 2/3 variables summarise don't list any of the variables in the survey data. It does in the other dialogs, and does in those for other datasets. So I tried the 2 way frequency table again and got a different error:

image

I tried other summaries and they worked fine

@lilyclements
Copy link
Contributor Author

Ok so we need to call count_label in R-Instat still. The labels we call in our R package (databook) are just for use in the R package, but when we call in R-Instat we need them to be in R-Instat.
So, I've updated the labels file to include only labels that are in R-Instat.
This means you need to update the databook (again, sorry) to get the other labels that are in the databook and aren't in R-Instat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Another missing item in the latest version
3 participants