Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the pivot-table dialog #9487

Merged
merged 4 commits into from
Mar 10, 2025

Conversation

Vitalis95
Copy link
Contributor

Fixes #9473
@rdstern @N-thony , added Factor Labels in Order control and changed Initial Column receiver to multiple receiver .

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vitalis95 and @lilyclements this already works and that's a wow! I really like it.
a) The one tiny edit is to check the intial order factor levels checkbox by default. So it should always start checked, and reset should make it checked again.
b) Initially the checking of that item didn't work in my test version. That's a temprorary limitation that the original version of the 4 packages is originally attached. So it doesn't find Lily's new function. Just detach and then attach (library) again and all works.

@Vitalis95
Copy link
Contributor Author

@rdstern , it's now checked by default

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vitalis95 and @lilyclements many thanks, that's great. And quite important. I can now finisdh more of the next presentation ready for @berylwaswa.
@N-thony over to you to approve and hopefully merge.

Copy link
Collaborator

@N-thony N-thony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vitalis95 this looks, I'm approving. I can see you made the database changes, it will be good to include the screenshots of the changes done there too.

@N-thony N-thony merged commit 03be1b9 into IDEMSInternational:master Mar 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the pivot-table dialog?
3 participants