Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download safeguarding files from Google Drive (optionally) #145

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

istride
Copy link
Collaborator

@istride istride commented Feb 14, 2025

During the 'pull' phase, the safeguarding XLSX workbook can be downloaded via the Google Drive API. The workbook must be uploaded to Drive as an XLSX file. Once uploaded, grab the Drive file id (from the URL) and add it to the 'sources' configuration for safeguarding.

"safeguarding": {
    "format": "safeguarding",
    "sources" : [
        {
            "key": "ara",
            "location": "1M9CgURmS433MuF1lwc4fMFYsmCJAUhE3"
        }
    ]
}

Note the key location, instead of path. Both path and location are usable, but only location will trigger a download from Drive. The path key should be considered deprecated and will be removed in a future release.

Resolves #143

@istride istride requested review from geoo89 and edmoss345 February 14, 2025 19:28
Copy link
Collaborator

@geoo89 geoo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll leave it to Ed to test this.

As per my comment in the issue, I thought this could be an opportunity to change the format of the safeguarding sheets to something more sane that can be handled by the standard source format, but this works too.

@istride istride force-pushed the download-safeguarding branch from 0051e40 to 67e3147 Compare February 20, 2025 22:26
@istride istride merged commit 18ad357 into main Feb 20, 2025
1 check passed
@istride istride deleted the download-safeguarding branch February 20, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update pipeline to read safeguarding file from google sheets
2 participants