Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlowParser: Default edge must be first edge #132

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

geoo89
Copy link
Contributor

@geoo89 geoo89 commented May 3, 2024

Only first edge of a row can be a default edge (unconditional from previous row). If a later edge is blank, it is omitted.

This fixes an issue when each edge was specified in a separate column, rather than as a single list of edges. The parser would then try to create many default edges in inappropriate places.

@geoo89
Copy link
Contributor Author

geoo89 commented May 16, 2024

I verified that the output produced for parenttext_crisis is identical before and after this commit.

@geoo89 geoo89 merged commit 859b56a into main May 16, 2024
12 checks passed
@istride istride deleted the restrict-default-edges branch November 23, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant