Skip to content

Conversation

@jburel
Copy link
Member

@jburel jburel commented Oct 29, 2025

Update the notebooks so they can be run in Google colab
Adding a notebook showing how to use complex queries via the search engine

@jburel jburel requested a review from will-moore October 29, 2025 12:29
@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch search_paper

@jburel jburel requested review from pwalczysko and removed request for will-moore October 29, 2025 12:29
Co-authored-by: pwalczysko <[email protected]>
"'''\n",
"**Query 1**\n",
"Organism Part Small intestine OR Duodenum\n",
"Pathology Adenocarcinoma (all) ==> contains (adenocarcinoma)\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a text cell before this one saying "Query 1: Searching for diseased tissue"

"outputs": [],
"source": [
"'''\n",
"**Query 2**\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a text cell before this one, saying "Query 2: Searching for normal tissue"

@pwalczysko
Copy link
Contributor

The blocker atm is that data variable is not defined:

  • humanmine notebook
  • Cell
from skimage.color import rgb2hed
# Convert the image to HED using the pre-built skimage method
ihc_hed = rgb2hed(data)

Errors with

---------------------------------------------------------------------------

NameError                                 Traceback (most recent call last)

[/tmp/ipython-input-384310487.py](https://localhost:8080/#) in <cell line: 0>()
      1 from skimage.color import rgb2hed
      2 # Convert the image to HED using the pre-built skimage method
----> 3 ihc_hed = rgb2hed(data)

NameError: name 'data' is not defined

@pwalczysko
Copy link
Contributor

Opened jburel#1 with some text suggestions.

Copy link
Contributor

@pwalczysko pwalczysko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above - couple of inline suggestions, a PR jburel#1 with reformulation suggestions and, mainly, the data variable definition problem.

Will continue review once the data var is fixed, as it blocks the tun of the notebook.

Copy link
Contributor

@pwalczysko pwalczysko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-tested both notebooks. Works fine.

The text suggestions are in. Lgtm. Thank you

@jburel jburel merged commit 51db5b5 into IDR:master Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants