-
Notifications
You must be signed in to change notification settings - Fork 20
Review notebooks #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review notebooks #127
Conversation
Co-authored-by: pwalczysko <[email protected]>
| "'''\n", | ||
| "**Query 1**\n", | ||
| "Organism Part Small intestine OR Duodenum\n", | ||
| "Pathology Adenocarcinoma (all) ==> contains (adenocarcinoma)\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a text cell before this one saying "Query 1: Searching for diseased tissue"
| "outputs": [], | ||
| "source": [ | ||
| "'''\n", | ||
| "**Query 2**\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a text cell before this one, saying "Query 2: Searching for normal tissue"
|
The blocker atm is that
Errors with |
|
Opened jburel#1 with some text suggestions. |
pwalczysko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above - couple of inline suggestions, a PR jburel#1 with reformulation suggestions and, mainly, the data variable definition problem.
Will continue review once the data var is fixed, as it blocks the tun of the notebook.
Reformat text only suggestions in humanmine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-tested both notebooks. Works fine.
The text suggestions are in. Lgtm. Thank you
Update the notebooks so they can be run in Google colab
Adding a notebook showing how to use complex queries via the search engine