Sending Emails asynchronously using Celery#222
Closed
VarshiniAdurti28 wants to merge 8 commits intoIEEE-NITK:mainfrom
Closed
Sending Emails asynchronously using Celery#222VarshiniAdurti28 wants to merge 8 commits intoIEEE-NITK:mainfrom
VarshiniAdurti28 wants to merge 8 commits intoIEEE-NITK:mainfrom
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: corpus/corpus/decorators.py
Did you find this useful? React with a 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Emails can now be sent asynchronously using Celery.
A service for redis and celery has been added to the dev docker compose file.
Fixes # (issue)
Dependencies
List any dependencies that are required for this change.
Type of Change
What types of changes does your code introduce?
Put an
xin the boxes that applyHow Has This Been Tested?
This has been tested using a dummy views file in corpus directory itself. We already had send_email in utils.py which was the one being used till now.
sample_email.html is used for the template_path.
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.