Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11/npm dependency merge #9086

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

lscharmer
Copy link
Contributor

Hi,
this PR merges the following npm dependency PRs:

Please note the following points

eslint + eslint-config-airbnb-base

The list doesn't include the accepted Dependency #8669 (eslint-config-airbnb-base).
We require eslint v9.16 which conflicts with eslint-config-airbnb-base's requirement for eslint v8.2. But as this version is already EOL (see: https://eslint.org/version-support/) I opt for dropping eslint-config-airbnb-base instead of downgrading eslint until this is decided. @thibsy As you suggest both dependencies: Can you provide a way forward?

Updated asset paths

I adjusted asset paths in the following Component classes, so that composer install doesn't fail:

  • ILIAS\Calendar: Dropped package moment (@smeyer-ilias)
  • ILIAS\UI: Renamed path in package @yaireo/tagify (@Amstutz / @klees)
  • ILIAS\UIComponent: Dropped package jstree
  • ILIAS\jQuery: Dropped package jquery

If these changes should be made in another PR (not by me) I can drop these instead.

@lscharmer lscharmer added the dependencies Pull requests that update a dependency file label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant