Add threaded-timer support to hpc-benchmark #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlober
requested changes
Dec 18, 2024
| d[timer] -= intermediate_kernel_status[timer] | ||
| if type(d[timer]) == tuple or type(d[timer]) == list: | ||
| timer_array = tuple(d[timer][tid] - intermediate_kernel_status[timer][tid] for tid in range(len(d[timer]))) | ||
| d[timer] = timer_array[0] |
There was a problem hiding this comment.
What is the reason for adding only the first value of the tuple to the logfile? And why is this handled differently for the presim timers?
There was a problem hiding this comment.
Just adding the first value would be equivalent to just measuring on the master thread, i.e., makes the data comparable with pre-threaded-timer data. This is just required for now, as beNNch only handles scalar data at the moment.
There was a problem hiding this comment.
I see thanks. But why is this handled differently for sim time and presim time?
There was a problem hiding this comment.
That was just an oversight from my side, I added the same code for presim as well now!
Fixed memory measurement for step-wise data collection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge this as soon as nest/nest-simulator#3378 is merged into NEST