-
Notifications
You must be signed in to change notification settings - Fork 553
MNT Fix several FutureWarnings #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ogrisel
merged 6 commits into
INRIA:update-to-scikit-learn-1.6
from
ArturoAmorQ:fix_warnings
Apr 2, 2025
Merged
MNT Fix several FutureWarnings #810
ogrisel
merged 6 commits into
INRIA:update-to-scikit-learn-1.6
from
ArturoAmorQ:fix_warnings
Apr 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
reviewed
Apr 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick feedback. I will merge and trigger a sync of the notebooks to check the results.
ogrisel
reviewed
Apr 2, 2025
Co-authored-by: Olivier Grisel <[email protected]>
glemaitre
reviewed
Apr 2, 2025
glemaitre
approved these changes
Apr 2, 2025
ogrisel
added a commit
that referenced
this pull request
May 27, 2025
* Feature branch to update to 1.6 * MNT Fix several FutureWarnings (#810) * MTN Wrap up quiz sklearn 1.6 verification (#817) * MAINT Use class_of_interest in DecisionBoundaryDisplay (#772) * Resync everything --------- Co-authored-by: Arturo Amor <[email protected]> Co-authored-by: SebastienMelo <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2025
* Feature branch to update to 1.6 * MNT Fix several FutureWarnings (#810) * MTN Wrap up quiz sklearn 1.6 verification (#817) * MAINT Use class_of_interest in DecisionBoundaryDisplay (#772) * Resync everything --------- Co-authored-by: Arturo Amor <[email protected]> Co-authored-by: SebastienMelo <[email protected]> c9728c8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows from #790.
Bumping the version scikit-learn to v1.6 introduced some FutureWarnings. This PR fixes them, as well as a
FutureWarning
related to resampling time indexed data.Note: As mentioned in #789 (comment), auto-updates are disabled on FUN, where still run on scikit-learn v1.3. Therefore building the notebooks after this PR should be done in combination with an update of the Jupyter image in FUN.