Feature branch to update to 1.6 #813
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI I ran the script introduced in #817 and manually compared the output with our expected results for all of the wrap-up quizzes. Everything seems to be working as intended for v1.6. You have my green light to bumping to 1.6 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: do not merge while the jupyterhub container has not been updated to scikit-learn 1.6.
Fixes: #789.
The
update-to-scikit-learn-1.6branch is meant to be used as a temporary target for all PRs related to the update to the latest version of the scikit-learn library.We are free to sync-execute the notebooks in this branch to test that the code works without warnings against the latest version of scikit-learn.
Once done, and once we have checked that the code in the wrap-up quiz solution works in the private repo, we can resync all notebooks / exercises using the Makefile and merge this branch and update the jupyterhub container.