Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

issue: #7 | PyTest, Makefile & Coverage Report #22

Merged
merged 16 commits into from
Oct 11, 2019

Conversation

suv27
Copy link
Contributor

@suv27 suv27 commented Oct 4, 2019

Description:

Start unit tests for yarpc/*.py Python files.
For Help, run make help

Tasks

  • Unit test enums.py
  • Unit test constants.py
  • Integrated pytest & name-tests-test into Travis CI Pipeline.
  • Integrated the coverage report to the project.

Pre-Pull Request Checklist:

  • Run make test
  • Run make openReport
  • Resolves issue Tests #7

@codecov
Copy link

codecov bot commented Oct 4, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@7d04bfa). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #22   +/-   ##
=========================================
  Coverage          ?   46.84%           
=========================================
  Files             ?       11           
  Lines             ?      333           
  Branches          ?        0           
=========================================
  Hits              ?      156           
  Misses            ?      177           
  Partials          ?        0
Impacted Files Coverage Δ
tests/unit/client_test.py 100% <ø> (ø)
tests/unit/constants_test.py 100% <100%> (ø)
tests/unit/enums_test.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d04bfa...7e17cac. Read the comment docs.

@Fogapod
Copy link
Member

Fogapod commented Oct 5, 2019

Unit Tests for the enums.py file and let me know if this is how you want it done.

This looks like what I wanted.

I'm not sure about file/folder naming though. Tests are usually named using snake_case and aren't strictly tied to classes. They're rather grouped by functionality. Examples:

@suv27
Copy link
Contributor Author

suv27 commented Oct 5, 2019

How would you want the structure for the test files inside of tests/?
The rest of the python files that need to I need to test it are this: python files
I do not see any more inside of this repo.

@suv27 suv27 changed the title issue: #7 | Unit Tests for Enums.py issue: #7 | PyTest, Makefile & Coverage Report Oct 5, 2019
@Fogapod
Copy link
Member

Fogapod commented Oct 5, 2019

tests/unit is fine

@suv27 suv27 mentioned this pull request Oct 7, 2019
@suv27 suv27 requested a review from Fogapod October 8, 2019 00:55
@suv27 suv27 requested a review from Fogapod October 9, 2019 05:44
@Fogapod
Copy link
Member

Fogapod commented Oct 10, 2019

@Physsix27 Will you be adding other tests to this pr or it's ready?

@suv27
Copy link
Contributor Author

suv27 commented Oct 10, 2019

@Fogapod @Gelbpunkt This PR is ready, I will make another PR specifically targeting tests. Let me know if anything is missing for this PR

@Fogapod Fogapod merged commit 32c7e94 into IOMirea:master Oct 11, 2019
@suv27 suv27 deleted the feat(unittest) branch October 11, 2019 20:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants